Skip to content

[lldb] Script determinism of TestSwiftActorUnprioritisedJobs #10435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: stable/20240723
Choose a base branch
from
Open

[lldb] Script determinism of TestSwiftActorUnprioritisedJobs #10435

wants to merge 10 commits into from
+49 −13

Conversation

kastiglione
Copy link

No description provided.

@kastiglione kastiglione requested a review from a team as a code owner April 4, 2025 22:30
@kastiglione
Copy link
Author

another attempt at #10417

@kastiglione
Copy link
Author

kastiglione commented Apr 5, 2025 •
edited
Loading

Old CI logs

1st run ✅ https://ci.swift.org/job/apple-llvm-project-pr-macos/7089/
2nd run ✅ https://ci.swift.org/job/apple-llvm-project-pr-macos/7092/
3rd run ✅ https://ci.swift.org/job/apple-llvm-project-pr-macos/7094/
4th run ✅ https://ci.swift.org/job/apple-llvm-project-pr-macos/7096/
5th run ✅ https://ci.swift.org/job/apple-llvm-project-pr-macos/7097/
6th run ✅ https://ci.swift.org/job/apple-llvm-project-pr-macos/7098/
7th run ✅ https://ci.swift.org/job/apple-llvm-project-pr-macos/7099/
8th run ✅ https://ci.swift.org/job/apple-llvm-project-pr-macos/7100/
9th run ✅ https://ci.swift.org/job/apple-llvm-project-pr-macos/7102/

@kastiglione
Copy link
Author

@swift-ci test macOS

@artemcm
Copy link

artemcm commented Apr 8, 2025

@swift-ci test Linux platform

@artemcm
Copy link

artemcm commented Apr 8, 2025

@swift-ci test Windows platform

@kastiglione kastiglione force-pushed the dl/lldb-Script-determinism-of-TestSwiftActorUnprioritisedJobs branch from 12f1313 to 0335696 Compare April 15, 2025 21:07
@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

Resuming work on this PR

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

kastiglione commented Apr 16, 2025 •
edited
Loading

macOS CI logs:

Linux CI logs:

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

So far, tests are passing consistently.

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test linux

adrian-prantl
adrian-prantl reviewed Apr 19, 2025
View reviewed changes
lldb/test/API/lang/swift/async/actors/unprioritised_jobs/TestSwiftActorUnprioritisedJobs.py
self.dbg.SetAsync(True)
process.Continue()
# Wait - allowing other threads to run.
time.sleep(5)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually do something like this (copied from another test)

DEFAULT_TIMEOUT = 20 * (10 if ("ASAN_OPTIONS" in os.environ) else 1)

to guard against even slower as an bots.

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test macOS

1 similar comment
@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test linux

1 similar comment
@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian-prantl adrian-prantl adrian-prantl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kastiglione @artemcm @adrian-prantl